Improving ComboBoxColumn behavior to prevent triple click behavior #4220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 3 times for DropDown expansion
|
Thanks bolyb for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
requested review from
ghost
added
bug 🐛
8 tasks
XAML-Knight
approved these changes
Sep 2, 2021
Rosuavio
reviewed
Sep 2, 2021
Microsoft.Toolkit.Uwp.UI.Controls.DataGrid/DataGrid/DataGridComboBoxColumn.cs
Outdated
Show resolved
Hide resolved
…mboBoxColumn.cs Co-authored-by: Rosario Pulella <[email protected]>
michael-hawker
approved these changes
Sep 2, 2021
|
Hello @michael-hawker! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3161
This implementation fixes the need to click a ComboBox in a DataGridComboBoxColumn 3 times before the DropDown opens.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The current behavior is that in order to expand a ComboBox DropDown, the cell must first be clicked once to be highlighted, then the ComboBox must be clicked twice more before the DropDown expands.
For more information, see: #3161
What is the new behavior?
The new behavior is that after the ComboBox is clicked once to be highlighted, the next click expands the DropDown.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Supersedes #4209